Skip near-complete progress updates before "Pull complete" #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip showing "Downloading" state when layer is >= 99.5% complete to avoid visual noise before "Pull complete" message. This addresses the issue where layers show almost-complete progress (e.g., 91.69MB/91.73MB) right before showing "Pull complete". Added comprehensive tests to verify the fix works correctly for various completion percentages. Co-authored-by: ericcurtin <[email protected]>
Co-authored-by: ericcurtin <[email protected]>
Copilot
AI
changed the title
[WIP] Fix download output for model pull command
Skip near-complete progress updates before "Pull complete"
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress output was showing nearly-complete "Downloading" states (e.g., 91.69MB/91.73MB) immediately before "Pull complete", creating visual noise.
Changes
cmd/cli/desktop/progress.go: Skip "Downloading" state when layer is ≥99.5% completecmd/cli/desktop/progress_test.go: Add tests covering completion thresholds and the specific issue scenarioExample
Before:
After:
The 99.5% threshold filters updates that occur within the final progress reporting interval while preserving meaningful progress indication during downloads.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.